Fix assert_matching_tables #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The csv_renewed and distribute_task functions return a table with the ints converted to strs
The function definition of match_column states that if there are 2 columns with the same normalized name, the latter should be removed by default. The normalize_fn function must run over the reversed list of self.columns in order for the first matching column to be kept. In it's previous state, the last matching column was kept
To match order in airtable_responses.py
Current test is returning the Lyndon Johnson lead twice
Fix typo in test. Also change import unittest to import unittest.mock to avoid `AttributeError: module 'unittest' has no attribute 'mock'` when running test locally
|
After this change, a few CircleCI tests failed. This is because those tests either had typos or flaws which weren't being caught in the I went ahead and fixed those tests. |
shaunagm
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
utils.py, when comparingassert list(r1) == list(r2), ifr1andr2are typedict, this only compares if the headers ofr1andr2are equal, when it should be comparing if the entire contents of both dicts are equal.This is why the
test_google_admin.pytest was passing even though it had a typo and should have failed. This typo is also fixed in this PR