Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_env_token option to S3 object #745

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add use_env_token option to S3 object #745

merged 1 commit into from
Sep 22, 2022

Conversation

sjwmoveon
Copy link
Collaborator

Previously this was only settable in AWSConnection, but you can't pass an AWSConnection to the S3 object.

@sjwmoveon
Add use_env_token option to S3 object
0d63427 
Previously this was only settable in AWSConnection, but you can't pass an AWSConnection to the S3 object.
@sjwmoveon
Copy link
Collaborator Author

@shaunagm here's the new pull request, following up on #740

shaunagm
shaunagm approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shaunagm shaunagm merged commit 4775b5d into move-coop:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunagm shaunagm shaunagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjwmoveon @shaunagm