Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cormac mobilecommons connector #730

Closed
wants to merge 6 commits into from
Closed

Cormac mobilecommons connector #730

wants to merge 6 commits into from

Conversation

cmdelrio
Copy link
Contributor

Thank you Daniel! Let me know if I can clarify anything.

dannyboy15
dannyboy15 reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@dannyboy15 dannyboy15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I left comments mostly to tidy up the code, and I didn't see any logic error. Let me know if you have questions or want to me to explain something further.

parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
parsons/mobilecommons/mobilecommons.py Show resolved Hide resolved
@shaunagm shaunagm added the new connector Work type - creating a new Parsons connector for a tool label Nov 15, 2022
@sharinetmc
Copy link
Contributor

Hi @cmdelrio! I just wanted to see where you were at making the changes danny suggested?

@cmdelrio
Copy link
Contributor Author

@sharinetmc I think I actually incorporated all of these. This connector is basically ready, but I haven't had the chance to write unit tests.

shaunagm
shaunagm requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating this so it has the correct Github status of "request changes", let me know how if/when you've got time to update this, happy to help however I can.

@shaunagm
Copy link
Collaborator

Closed in favor of #896

@shaunagm shaunagm closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyboy15 dannyboy15 dannyboy15 left review comments

@shaunagm shaunagm shaunagm requested changes

Assignees
No one assigned
Labels
new connector Work type - creating a new Parsons connector for a tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmdelrio @sharinetmc @shaunagm @dannyboy15