-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cormac mobilecommons connector #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I left comments mostly to tidy up the code, and I didn't see any logic error. Let me know if you have questions or want to me to explain something further.
Hi @cmdelrio! I just wanted to see where you were at making the changes danny suggested? |
@sharinetmc I think I actually incorporated all of these. This connector is basically ready, but I haven't had the chance to write unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating this so it has the correct Github status of "request changes", let me know how if/when you've got time to update this, happy to help however I can.
Closed in favor of #896 |
Thank you Daniel! Let me know if I can clarify anything.