VAN: Fix codes bugs. #696
Merged
VAN: Fix codes bugs. #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburchard
added
the
bug
shaunagm
approved these changes
Jun 2, 2022
|
Yes, yes. Good call. Someone (me) many years ago, probably ran out of steam when writing the tests. I'll take a look. |
|
Test added. Ready for re-review. @shaunagm |
|
Looks good to me. Thanks for adding the test, @jburchard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small bug fixes:
get_code: The method for the underlying VANConnector class was misnamed.apply_code: The is_applicable parameter was misnamed and thus, not applying.Furthermore, I might want to rework the _supported_entities parameter. It requests constructing a dict, which is sort of unnecessary and not keeping with the common sense abstraction of Parsons. But, that would come in another PR.