-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newmode v2 #1227
Open
sharinetmc
wants to merge
30
commits into
main
Choose a base branch
from
add-newmode-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add newmode v2 #1227
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f1c7d8c
add init
sharinetmc 922e89a
edit connectors
sharinetmc 9a0bf4a
add tests
sharinetmc 03735d3
add v2
sharinetmc 2e15310
ruff format
sharinetmc eb89e07
clean up
sharinetmc 71283ed
Merge branch 'main' into add-newmode-v2
sharinetmc e9bbadc
collapse classes and add back submissions
sharinetmc 606f7e0
clean up
sharinetmc 6a48b2a
add docstrings
sharinetmc 8d0bb95
clean up docstrings + unittests
sharinetmc afe9716
clean up
sharinetmc 9a351e0
ruff
sharinetmc fa414d9
clean up test
sharinetmc 362bbb9
ruff
sharinetmc a9a99ba
clean up
sharinetmc 1e7b030
typo
sharinetmc 34340f1
fix name
sharinetmc 3521c08
typo
sharinetmc d92fdc0
typo
sharinetmc d38077e
typo
sharinetmc 234f058
typo
sharinetmc 3ad19f1
typo
sharinetmc 4cc54c0
add validation
sharinetmc c689a0c
revert
sharinetmc 63724a3
ruff
sharinetmc fce0852
clean up
sharinetmc d41c815
more clean up
sharinetmc 1586971
clean up test
sharinetmc 443729c
ruff
sharinetmc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import logging | ||
import urllib.parse | ||
from simplejson.errors import JSONDecodeError | ||
from parsons import Table | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
@@ -306,3 +307,13 @@ def json_check(self, resp): | |
return True | ||
except JSONDecodeError: | ||
return False | ||
|
||
def convert_to_table(self, data): | ||
"""Internal method to create a Parsons table from a data element.""" | ||
table = None | ||
if type(data) is list: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
table = Table(data) | ||
else: | ||
table = Table([data]) | ||
|
||
return table |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and just to confirm - v1 is cutoff entirely in Feb? I'm just worried about how little notice we're giving folks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the comment above, we're still ~a month out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, forgot to update this comment after that update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put Feburary first bc I didn't know the exact date.