Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to update phone, order user detail, and import action #1074

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

technicalex
Copy link
Contributor

This pull request:

  • Adds methods to update phone, order user detail, and import action in ActionKit
  • Adds corresponding unit tests
  • Fixes code comments/documentation for the update_user() function

@codygordon codygordon self-requested a review June 11, 2024 13:36
Copy link
Collaborator

@codygordon codygordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @technicalex!

Just one suggestion: since these seem to be more esoteric endpoints that aren't well-documented by AK, it would be helpful to add a bit more to the docstring descriptions about what they do exactly and how they might be used.

@technicalex
Copy link
Contributor Author

Thanks for the suggestion, @codygordon! I improved the documentation.

@codygordon codygordon merged commit 3ff0eac into move-coop:main Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants