BigQuery extract table method #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
approved these changes
May 23, 2024
There was a problem hiding this comment.
This looks good to me and seems fairly straightforward. A test would be nice but I trust it worked locally for you and we'd have to mock the test anyway, so it'd only be a help for a hypothetical future person debugging this.
If you want to merge it as-is, go ahead. You can also wait for Jason to review if you want someone with BigQuery experience reviewing. Up to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #921
Unlike in Redshift, you can't directly export query results to GCS. You can only extract a table.