Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return PATCH response when updating AK user #1024

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Return PATCH response when updating AK user #1024

merged 1 commit into from
Apr 4, 2024

Conversation

crayolakat
Copy link
Collaborator

Return the response after patching an AK user. This is necessary to parse the status code after calling the update_user function

shaunagm
shaunagm approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - technically kind of a breaking change but I don't know who would be relying on this method returning None so I think it's okay to merge here instead of into the next major release.

@shaunagm shaunagm merged commit 7fad0e4 into move-coop:main Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunagm shaunagm shaunagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crayolakat @shaunagm