Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing linting test in #827 #1020

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Mar 16, 2024

This fixes workflow errors in #827 by correcting formatting by changing quotes to double and making a slight change in how a long line is wrapped.

I also had to cherry-pick d4e85ab to get doc build to pass because the branch is outdated.

bmos and others added 2 commits March 16, 2024 09:34
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunagm shaunagm merged commit 2f5e52b into move-coop:add_encoding_arg_to_copy_s3_func Apr 4, 2024
1 check passed
@bmos bmos deleted the patch-4 branch April 4, 2024 20:33
shaunagm added a commit that referenced this pull request May 23, 2024
* added encoding

* fix linting issue

* Fix failing linting test in #827 (#1020)

* fix black error

* Bump Multiple Docs Deps Around Sphinx (#975)

* Bump multiple docs deps

* Downgrade myst-parser

---------

Co-authored-by: Soren Spicknall <soren@spicknall.us>

---------

Co-authored-by: Wil T <wil.thieme@protonmail.com>
Co-authored-by: Soren Spicknall <soren@spicknall.us>
Co-authored-by: Shauna <shaunagm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants