Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flake8, black, and pytest configs to pyproject.toml #1013

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Mar 14, 2024

Consolidating tooling configs here is neater and helps avoid fragmented options (like how flake8 was set to 100 line length but black was set to 88).

This also updates these tools to their latest versions.

If you would rather use a different line length like 88 (the black default) or 79 (the flake8 default) or something else, this PR can be edited. I just used 100 since it was already configured in the flake8 config file.

@bmos bmos marked this pull request as draft March 14, 2024 02:34
@bmos bmos marked this pull request as ready for review March 14, 2024 02:45
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. It looks good to me, although I don't love re-linting all the files it's probably worth it from a readability perspective to give them all the longer line length.

@shaunagm shaunagm merged commit 1af776c into move-coop:main Apr 4, 2024
10 checks passed
@bmos bmos deleted the tooling-configs branch April 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants