Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team_project_doga #6

Merged
merged 2 commits into from
Aug 20, 2024
Merged

team_project_doga #6

merged 2 commits into from
Aug 20, 2024

Conversation

dogagzm
Copy link
Collaborator

@dogagzm dogagzm commented Aug 18, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

can you review my visuals Oleg? Thanks

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Checklist

  • I can confirm that my changes are working as intended

@dogagzm dogagzm requested a review from movcha August 18, 2024 00:29
Copy link
Owner

@movcha movcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no contradictions, can be merged

@krishnakishore163 krishnakishore163 merged commit 4fcbf52 into main Aug 20, 2024
@liujinro
Copy link
Collaborator

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants