fix: always create empty directory under controlpath #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix moul#393. Also remove gateway name from `%h` realce in `expandSSHTokens`. Only add the gateway name in the path here has no effect to raw `ssh` command, because the raw `ssh` command will only replace the `%h` with the remote hostname.
moul
approved these changes
Feb 17, 2021
moul
changed the title
|
🎉 This PR is included in version 2.11.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #393.
Also, remove the gateway name from
%hreplace inexpandSSHTokens. Onlyadd the gateway name in the path here has no effect on raw
sshcommand, because the raw
sshcommand will only replace the%hwiththe remote hostname.