Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't disable folder creation for control path #393

Closed
wd opened this issue Jan 25, 2021 · 2 comments · Fixed by #394
Closed

Can't disable folder creation for control path #393

wd opened this issue Jan 25, 2021 · 2 comments · Fixed by #394
Labels
released

Comments

@wd
Copy link
Contributor

wd commented Jan 25, 2021 •
edited
Loading

I saw this PR: #183 . If I understand correctly, the creation will only happen after I enabled the ControlMasterMkdir.

These are the debug messages

DEBUG   Proxying
DEBUG   Creating control path   {"path": "/Users/wd/.ssh/cm"}
DEBUG   Trying gateways {"gateways": "bastion-staging"}
2021/01/25 17:11:56 bastion-staging
DEBUG   getHostByName direct matching   {"name": "bastion-staging"}
DEBUG   Creating control path   {"path": "/Users/wd/.ssh/cm/172.x.x.x"}
DEBUG   Using gateway   {"gateway": "bastion-staging", "command": "ssh -W 172.x.x.x:22 %name"}
DEBUG   ProxyCommand    {"command": "ssh -W 172.x.x.x:22 bastion-staging"}

My settings in defaults, I only have this ControlPath set in defaults section.

defaults:
    ControlMaster: auto
    ControlPath: ~/.ssh/cm/%h-%p-%r.sock
    IdentitiesOnly: yes
    ControlPersist: yes
    UseKeychain: yes
    AddKeysToAgent: yes
    ServerAliveInterval: 30
@wd
Copy link
Contributor Author

wd commented Jan 25, 2021 

$ brew info assh
assh: stable 2.11.0 (bottled), HEAD
Advanced SSH config - Regex, aliases, gateways, includes and dynamic hosts
https://manfred.life/assh
/usr/local/Cellar/assh/2.10.0 (6 files, 12.3MB) *

wd added a commit to wd/assh that referenced this issue Jan 25, 2021
@wd
Fix: always create empty directory under controlpath
e9441de 
Fix moul#393.

Also remove gateway name from `%h` realce in `expandSSHTokens`. Only
add the gateway name in the path here has no effect to raw `ssh`
command, because the raw `ssh` command will only replace the `%h` with
the remote hostname.
@wd wd mentioned this issue Jan 25, 2021
Merged
@moul moul closed this as completed in #394 Feb 17, 2021
moul pushed a commit that referenced this issue Feb 17, 2021
@wd
fix: always create empty directory under controlpath (#394)
7a2307e 
Fix #393.

Also remove gateway name from `%h` realce in `expandSSHTokens`. Only
add the gateway name in the path here has no effect to raw `ssh`
command, because the raw `ssh` command will only replace the `%h` with
the remote hostname.
@github-actions
Copy link

🎉 This issue has been resolved in version 2.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always create empty directory under controlpath wd/assh
1 participant
@wd