Fix: Adjust wrong number of arguments #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #183 (Wrong number of arguments in the replace_bind_variables method)
Description:
I have implemented a fix for the issue related to the "wrong number of arguments" error in the replace_bind_variables method. This adjustment specifically addresses compatibility with Rails version 7.2 and above.
If any adjustments are needed, I am available to help.
This pull request includes changes to the
lib/motor/queries/run_query.rb
file to improve the handling of SQL statements by passing the database connection as an argument. The most important changes are:Improvements to SQL statement normalization:
lib/motor/queries/run_query.rb
: Modified thenormalize_statement_for_sql
method to accept aconn
parameter and updated its implementation to conditionally include the connection based on the Rails version.Enhancements to query execution:
lib/motor/queries/run_query.rb
: Updated theexecute_query
method to pass the database connection to thenormalize_statement_for_sql
method.