Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean deploy function #220

Merged
merged 4 commits into from
Apr 6, 2017
Merged

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 6, 2017

The main fixed are below.

  • Clean unnecessary else
    • Deleted unnecessary else because it is return in if statement.
    • This will reduce nesting.

Deleted unnecessary `else` because it is` return` in `if` statement.
This will reduce nesting.
lib/main.js Outdated
@@ -597,6 +597,7 @@ Lambda.prototype.deploy = function (program) {
'FunctionName': params.FunctionName
}, function (err) {
if (err) {
// Function not exsits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exsits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed

@DeviaVir DeviaVir merged commit a6aacf6 into motdotla:master Apr 6, 2017
@abetomo abetomo deleted the clean_deploy_function branch April 11, 2017 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants