Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post install script environment #154

Merged
merged 3 commits into from
Sep 20, 2016

Conversation

navihtot
Copy link
Contributor

Passing environment string to post install script -> can be used to replace some config file depending on environment

@DeviaVir
Copy link
Collaborator

I would like to see a test for this, but noticed that postInstall has no tests at all yet so don't blame you for not creating them. +1, but keeping open for visibility to create tests later.

@navihtot
Copy link
Contributor Author

Well to be honest I did introduce this feature in the first place, so I am the one to blame 😊
Will write tests when i find time 👼

@navihtot
Copy link
Contributor Author

There, this should be enough. Didn't find any nicer way to capture console output in node. 😒

Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeviaVir DeviaVir merged commit 1d6405a into motdotla:master Sep 20, 2016
@DeviaVir DeviaVir mentioned this pull request Sep 20, 2016
@DeviaVir
Copy link
Collaborator

This is now available on NPM v0.8.10

@navihtot
Copy link
Contributor Author

great, thanks!

@navihtot navihtot deleted the post-install-script-environment branch September 20, 2016 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants