Do not use zstd.Decoder.DecodeAll on untrusted data #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to also publish an advisory from this repo, so that consumers of the library will get automatically notified by GitHub (dependabot), as well as third-party security vulnerability scanners? |
Will do, once I figure out how :) |
mostynb
commented
Jun 6, 2024
internal/zstd/zstd.go
Outdated
| wrapper := &decoderWrapper{Decoder: decoder} | ||
| runtime.SetFinalizer(wrapper, func(dw *decoderWrapper) { | ||
| err := dw.Reset(nil) | ||
| if err != nil { |
Otherwise, malicious peers could DoS us with decompression bombs. This issue was uncovered during a security audit performed by 7ASecurity, facilitated by OSTIF, for the OpenTelemetry project. https://opentelemetry.io/blog/2024/cve-2024-36129/ GHSA-c74f-6mfw-mm4v
mostynb
force-pushed
the
avoid_zstd_decodeall_dos
branch
from
1e8e147 to
53bfa61
Compare
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, malicious peers could DoS us with decompression bombs.
This issue was uncovered during a security audit performed by 7ASecurity, facilitated by OSTIF, for the OpenTelemetry project.
https://opentelemetry.io/blog/2024/cve-2024-36129/ GHSA-c74f-6mfw-mm4v