Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrade VS2019 support #354

Closed
hsdk123 opened this issue Jul 14, 2019 · 3 comments
Closed

Corrade VS2019 support #354

hsdk123 opened this issue Jul 14, 2019 · 3 comments

Comments

@hsdk123
Copy link
Contributor

hsdk123 commented Jul 14, 2019

Magnum doesn't configure on CMake properly for VS2019 with error:

To use Corrade with MSVC 2019, build it with MSVC2019_COMPATIBILITY enabled

Even if I do define MSVC2019_COMPATIBILITY, configure doesn't work.
If I define CORRADE_MSVC2019_COMPATIBILITY, configure works.

@mosra mosra added this to the 2019.0b milestone Jul 14, 2019
@mosra
Copy link
Owner

mosra commented Jul 14, 2019

Hi!

This is most probably due to an outdated FindCorrade.cmake. Assuming this happens while configuring your own project (and not while building Magnum itself, there it seems to be okay), can you put a fresh copy of FindCorrade.cmake into your project's module directory and try again?

I'm aware that this problem happens with projects from the magnum-bootstrap repository, still need to update that one (sorry about that if that's the case).

@mosra mosra mentioned this issue Jul 14, 2019
60 tasks
@hsdk123
Copy link
Contributor Author

hsdk123 commented Jul 14, 2019

Hey! Yup, I was building from the magnum-bootstrap repo. Seems to work well with the new FindCorrade.cmake.

I was also just in the process of evaluating whether to shift my team to using Magnum. It's great to see such fast responses!

@mosra
Copy link
Owner

mosra commented Aug 4, 2019

As of mosra/magnum-bootstrap@0b384ce (and related changes in other repos), the magnum-bootstrap repo is finally updated for MSVC 2019 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants