-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Emscripten application #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'll merge this after I fix the bug with animation progress being negative.
31aa803
to
351ad0b
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
======================================
Coverage 18.7% 18.7%
======================================
Files 35 35
Lines 1449 1449
======================================
Hits 271 271
Misses 1178 1178 Continue to review full report at Codecov.
|
351ad0b
to
2bb3909
Compare
@mosra This is also ready for the next review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- can you rebase on latest master and try w/o the assert hotfix?
…ipten Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
2bb3909
to
3dfe7ca
Compare
Merged as a4caa32, 4828c09 and eca4562, the apps are also shipped on https://magnum.graphics/showcase/ and working nicely. I omitted 3ab1574 because while that one fixes it for cmd.exe, it breaks it on the macOS shell (Travis complaining):
This worked correctly on my bash, but apparently not on macOS. Not sure what's the proper fix 😅 |
Hi @mosra !
As part of mosra/magnum#300, here are the ports of
player
andui-gallery
.Best, Jonathan.