feature: URL prefix case-sensitive #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoyuanyuan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1637 +/- ##
==========================================
+ Coverage 59.22% 59.41% +0.18%
==========================================
Files 369 369
Lines 28665 28669 +4
==========================================
+ Hits 16978 17034 +56
+ Misses 9760 9714 -46
+ Partials 1927 1921 -6
Continue to review full report at Codecov.
|
nejisama
reviewed
Apr 25, 2021
| @@ -69,7 +70,11 @@ func newPrefixMatcher(rule *jwtauthnv3.RequirementRule) Matcher { | |||
| } | |||
|
|
|||
| func (p *prefixMatcher) Matches(headers api.HeaderMap, requestPath string) bool { | |||
| if p.baseMatcher.matchRoutes(headers, requestPath) && strings.HasPrefix(requestPath, p.prefix) { | |||
| prefixMatch := strings.HasPrefix(requestPath, p.prefix) | |||
| if !p.baseMatcher.caseSensitive { | |||
There was a problem hiding this comment.
这里是不是有重复计算。 先判断caseSensitive？
nejisama
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues associated with this PR
#1633
Solutions
make the configuration 'case_sensitive' work.