[ES-2250] preferring consent_expire_in_mins field over accessTokenExpireSeconds/idTokenExpireSeconds #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and idTokenExpireSeconds configuration Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
ase-101
reviewed
Mar 19, 2025
| TokenResponse tokenResponse = getTokenResponse(transaction, isTransactionVCScoped); | ||
| Optional<Integer> consentExpireSeconds = Optional.empty(); | ||
| JsonNode additionalConfig = clientDetailDto.getAdditionalConfig(); | ||
| if(additionalConfig != null && additionalConfig.get("consent_expire_in_mins") != null) { |
There was a problem hiding this comment.
in a recent PR, We have added a method in clientDetailDTo to fetch the value of a particular additionalConfig and return the default value if the entry is not present. Can we use the same method here?
There was a problem hiding this comment.
Ok I will check that
ase-101
reviewed
Mar 19, 2025
| Optional<Integer> consentExpireSeconds = Optional.empty(); | ||
| JsonNode additionalConfig = clientDetailDto.getAdditionalConfig(); | ||
| if(additionalConfig != null && additionalConfig.get("consent_expire_in_mins") != null) { | ||
| consentExpireSeconds = Optional.of(additionalConfig.get("consent_expire_in_mins").intValue()*60); |
There was a problem hiding this comment.
Create a constant for "consent_expire_in_mins" instead of defining the string everywhere.
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If consent_expire_in_mins is provided in additional_config during client creation it will override the accessTokenExpireSecods and idtokenExpireSeconds configuration.