Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a prefix in aedes module and drop ts functions #768

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Jul 31, 2022

A breaking change in TS

  • drop Server() and Aedes() ts export functions
  • add a prefix in aedes modules

Sample usage

import Server, { Aedes } from 'aedes:server'
// the above is same as below
// import Server, { Aedes } from 'aedes'

let broker = new Server()
broker = new Aedes()

@coveralls
Copy link

coveralls commented Jul 31, 2022

Pull Request Test Coverage Report for Build 2768720997

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.824%

Totals Coverage Status
Change from base Build 2745421526: 0.0%
Covered Lines: 808
Relevant Lines: 808

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando
Copy link
Member

Should we go for 1.0.0 ?

@gnought
Copy link
Collaborator Author

gnought commented Aug 1, 2022

The core doesn't change. IMO it is sufficient to bump a minor version for just TS declaration updates.

A LWT authorise fix is coming, mind to wait?

@robertsLando
Copy link
Member

Sure 👍🏼 Glad to see you back :)

@robertsLando robertsLando merged commit 6e23068 into main Aug 1, 2022
@gnought gnought deleted the feat/ts-upate branch August 1, 2022 14:52
@robertsLando
Copy link
Member

robertsLando commented Sep 29, 2022

This seems to have break something on my instance:

import { Client } from 'aedes:client';

Error:

error TS2614: Module '"aedes"' has no exported member 'Client'. Did you mean to use 'import Client from "aedes"' instead?

14 import { Client } from 'aedes';

@gnought could you fix it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants