Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove superfluous ClientId type definition #743

Merged
merged 2 commits into from
May 13, 2022

Conversation

seriousme
Copy link
Contributor

As discussed in #741 (comment)

Kind regards,
Hans

types/packet.d.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 13, 2022

Pull Request Test Coverage Report for Build 2320068032

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.824%

Totals Coverage Status
Change from base Build 2317766017: 0.0%
Covered Lines: 808
Relevant Lines: 808

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit b4e7688 into moscajs:main May 13, 2022
@seriousme seriousme deleted the revert-741 branch May 13, 2022 15:21
chfritz pushed a commit to chfritz/aedes that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants