Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing CPU usage calculation #12

Merged
merged 9 commits into from
Jul 9, 2020
Merged

Implementing CPU usage calculation #12

merged 9 commits into from
Jul 9, 2020

Conversation

r3na
Copy link
Contributor

@r3na r3na commented Jul 9, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2020

This pull request introduces 1 alert when merging d0ef1b6 into 0e5b71a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@robertsLando
Copy link
Member

@r3na Thanks for your PR, please fix ci and remember to also write a test for the new feature

@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 163494880

  • 24 of 24 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 94.366%
Totals Coverage Status
Change from base Build 0e5b71a20c88f48f0fd13ac2d5aac3b8fe34c58e: 1.3%
Covered Lines: 54
Relevant Lines: 55
💛 - Coveralls

@r3na
Copy link
Contributor Author

r3na commented Jul 9, 2020

@robertsLando done
reference:
https://gist.github.com/bag-man/5570809

mcollina
mcollina approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@r3na
Copy link
Contributor Author

r3na commented Jul 9, 2020

sorry, I felt the need to implement this one as well
https://nodejs.org/api/os.html#os_os_loadavg

@mcollina @robertsLando

@r3na r3na mentioned this pull request Jul 9, 2020
Closed
robertsLando
robertsLando approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando
Copy link
Member

@r3na Can I merge this or would you like to add some other stat?

@r3na
Copy link
Contributor Author

r3na commented Jul 9, 2020

@robertsLando i am done :D

@robertsLando robertsLando merged commit 025f8e0 into moscajs:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r3na @robertsLando @coveralls @mcollina