PUBLISH packet should NOT update the outgoing queue #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broker uses `brokerCounter` to track how many packets it emits, as `messageId` will be rotated after it reaches max 65535. If there are two PUBLISH packets which brokerCounter is different but same messageId, the second PUBLISH will update the first slot in the queue, as `outgoingUpdate` is using `for` loop starting at index 0. This will fix the issue. We use `outgoingEnqueue` or `outgoingEnqueueCombi` to enqueue PUBLISH packets, and and use `outgoingUpdate` to update those PUBLSIH items to next state (say PUBREL), so `outgoing` array should not contain PUBLISH, and that's why this issue could be fixed by a check `packet.cmd !== 'publish'`
mcollina
reviewed
Jul 15, 2019
|
What other persistences do you want to check? |
|
aedes-persistence-mongodb https://github.com/mcollina/aedes-persistence-mongodb aedes-persistence-redis https://github.com/mcollina/aedes-persistence-redis aedes-cached-persistence https://github.com/mcollina/aedes-cached-persistence They all treat aedes-persistence functions as interfaces, and implemented by themselves. Quite confident it won't affect those. |
|
what's the difference between this and #31? |
|
Just wanna submit a small change for ease to have a review. :) |
mcollina
requested changes
Jul 15, 2019
|
Can we close this and I review #31 instead? |
|
sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker uses
brokerCounterto track how many packets it emits, asmessageIdwill be rotated after it reaches max 65535. If there are two PUBLISH packets which brokerCounter is different but same messageId, the second PUBLISH will update the first slot in the queue, asoutgoingUpdateis usingforloop starting at index 0.We use
outgoingEnqueueoroutgoingEnqueueCombito enqueue PUBLISH packets, and and useoutgoingUpdateto update those PUBLSIH items to next state (say PUBREL), sooutgoingarray should not contain PUBLISH