Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientId and nl to be used in the bridged connection #67

Merged
merged 6 commits into from
May 4, 2022
Merged

Add clientId and nl to be used in the bridged connection #67

merged 6 commits into from
May 4, 2022

Conversation

oldrich-s
Copy link
Contributor

Part of a fix for: moscajs/aedes#736

@robertsLando
Copy link
Member

fix tests

@oldrich-s
Copy link
Contributor Author

I added new unit tests and made existing unit tests not fail.

@robertsLando
Copy link
Member

@mcollina @gnought thoughts on this?

mcollina
mcollina approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0f39720 into moscajs:master May 4, 2022
@robertsLando
Copy link
Member

@mcollina I was going to release version 3 but I'm not a collaborator of aedes-packet on npm. Could you fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@robertsLando robertsLando robertsLando approved these changes

@gnought gnought Awaiting requested review from gnought

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oldrich-s @robertsLando @mcollina