Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing dup field #3

Merged
merged 8 commits into from
Feb 11, 2020
Merged

Added a missing dup field #3

merged 8 commits into from
Feb 11, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Jul 14, 2019

No description provided.

@mcollina
Copy link
Collaborator

tests are failing.

@gnought
Copy link
Collaborator Author

gnought commented Jul 15, 2019

Aedes does not take care of dup flag. It needs to include it to stick to the spec. However this change will be massively affect other aedes-related packages.
Review later. :)

@mcollina
Copy link
Collaborator

CI is failing.

@robertsLando
Copy link
Member

@mcollina Was just a typo :)

@mcollina
Copy link
Collaborator

Could you add a unit test?

@robertsLando
Copy link
Member

@mcollina Tests are fixed now

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit 2bcfdab into moscajs:master Feb 11, 2020
@robertsLando
Copy link
Member

@mcollina Release?

@gnought gnought deleted the patch-1 branch February 11, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants