This repository has been archived by the owner on May 8, 2023. It is now read-only.
JSON Schema Support #123
Merged
JSON Schema Support #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Cool work! See comments.
In addition, for test cases, can you dump the kitchen sink hparams jsonschema to a file as a test fixture, and validate the kitchen sink hparams yaml against that? See https://github.com/mosaicml/yahp/blob/a3d21be2c810b95e56492548b11583f37a41de72/tests/fixtures/commented_map.yaml
|
Forgot to say, but can you also set the |
Co-authored-by: ravi-mosaicml <ravi@mosaicml.com>
Co-authored-by: ravi-mosaicml <ravi@mosaicml.com>
Co-authored-by: ravi-mosaicml <ravi@mosaicml.com>
…to mvpatel2000/json-schema
|
Would like a careful review on the logic here. A lot of subtle type stuff going on, and I'm still not 100% familiar with autoyahp / hparams_registry so there could be logic errors |
ravi-mosaicml
approved these changes
Jul 21, 2022
mvpatel2000
added a commit
that referenced
this pull request
Jul 28, 2022
This reverts commit 8d1880e.
|
Reverting and pushing to dev |
mvpatel2000
added a commit
that referenced
this pull request
Jul 28, 2022
mvpatel2000
added a commit
that referenced
this pull request
Jul 28, 2022
* JSON Schema Support (#123) * yaml validation * fix lint and typing * add IO tests * update installs * Update meta.yaml Co-authored-by: ravi-mosaicml <ravi@mosaicml.com> * Update setup.py Co-authored-by: ravi-mosaicml <ravi@mosaicml.com> * Update yahp/hparams.py Co-authored-by: ravi-mosaicml <ravi@mosaicml.com> * resolve multiple comments * support autoyahp * add optional support * support registries * switch to anyOf * nits and kitchen sink test Co-authored-by: ravi-mosaicml <ravi@mosaicml.com> * fix schema generator * fix lint * support singletons in list * support + syntax * add list test * add validation to create as default * fix many tests * compressed schemas * fix comments * update yahp with autoyahp * make schema sorted * missing copy * change enum * don't shortcut primitives * more aggressively type def * checkdown * checkdown * simplify cls_def * allow recursion * remove singleton shortcutting * add param and param prop * stack properties * one more round of comments * support type insensitive regex Co-authored-by: ravi-mosaicml <ravi@mosaicml.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRAs