Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Remove auto initailized hparams cls #119

Merged
merged 1 commit into from
May 26, 2022

Conversation

ravi-mosaicml
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml commented May 23, 2022

  • _create always returns an instance of Hparams. The caller is now responsible for initializing it if necessarry.
  • Removed the allow_autoinitialization flag, since the caller is responsible for initializing the object
  • Added a helper to handle the deferred create calls

* `_create` always returns an instance of `Hparams`. The caller is now responsible for initializing it if necessarry.
* Removed the `allow_autoinitialization` flag, since the caller is responsible for initializing the object
* Added a helper to handle the deferred create calls
@ravi-mosaicml ravi-mosaicml changed the base branch from main to dev May 23, 2022 22:56
Copy link
Contributor

@Averylamp Averylamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravi-mosaicml ravi-mosaicml merged commit e86709d into dev May 26, 2022
@ravi-mosaicml ravi-mosaicml deleted the remove_auto_initailized_hparams_cls branch May 26, 2022 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants