Skip to content

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Nov 22, 2022

No description provided.

@vchiley vchiley requested a review from abhi-mosaic November 22, 2022 19:34
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vchiley vchiley merged commit 63eb646 into main Nov 22, 2022
@vchiley vchiley deleted the vitaliy/license branch November 22, 2022 22:46
sophiawisdom added a commit to sophiawisdom/benchmarks-adafactor that referenced this pull request Dec 12, 2022
* ResNet Benchmark (mosaicml#25)

Updates the ResNet benchmark to no longer use yahp.

Co-authored-by: Matthew <growlix@users.noreply.github.com>
Co-authored-by: dblalock <dwb4ke@virginia.edu>

* correcting license and headers (mosaicml#29)

* Forgot to change branch in resnet benchmark... (mosaicml#30)

Forgot to change branch...

* Update LLM benchmark with eval, HF models, bugfixes (mosaicml#26)

* Ade20k benchmark (mosaicml#27)

* Vitaliy/compare hf mosaic (mosaicml#28)

* compare mosaic GPT vs HF GPT2

* cleanup

* updt abhi cmts

Co-authored-by: Vitaliy Chiley <vitaliy@moasic.com>

* Vitaliy/sync foundry tests (mosaicml#32)

* porting foundry tests

* rm unittest

* xfail test when dataset is not set up

Co-authored-by: Vitaliy Chiley <vitaliy@moasic.com>

* CIFAR benchmark  (mosaicml#31)

* Add cifar benchmark

Co-authored-by: dblalock <dwb4ke@virginia.edu>

* Add codeowners for each existing benchmark (mosaicml#36)

add codeowners for each existing benchmark

* fix torch attn init (mosaicml#38)

* add init for nn.MultiheadAttention

* Bert pre-training and fine-tuning on GLUE (mosaicml#24)

Adds benchmark examples for BERT pre-training and fine-tuning on GLUE, and features support for HF models as well as a Mosaic BERT which is implemented and introduced here.

See README.md for a detailed description of these components.

TODO in a future PR:
- README: Add final speedup results
- YAMLs: Add configuration files for experiments shown in results
- Tests

* Add precommit linting + get repo passing all checks (mosaicml#37)

This adds the following pre-commit checks:
    yapf
    pyright
    pycln
    isort
    inserting our license header into every python file
    docformatter
    pydocstyle
    yamllint
    yamlfmt

This is mostly a copy-pasted .pre-commit-config.yaml, pyproject.toml, and .yamllint.yaml 
from the streaming repo, along with the associated code autoformating. There was some manual
intervention to fix license headers and occasional edge cases where the linters/formatters couldn't
all agree (e.g., spacing before a function in another function without a docstring).

I also just tightened up some of the docstrings when I was already making them satisfy the linters.

* Update flash attn version (mosaicml#40)

* Update flash attn version

* Update llm/requirements.txt

Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>

Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>

* Update URL to streaming docs

* printing state

* change batch number for fast forwarding

* fast forward batches properly

* Raise error if global batch size not divisible by world size (mosaicml#41)

Adding in batchsize error, s.t. a user won't accidentally use an incorrect batchsize

* fixed save_overwrite

* hard peg version of mosaicml-streaming

* set mosaicml-streaming constraint to <0.2.0

* fixed part of bad merge

* mostly back to sophia's version

* mcli-streaming<0.2.0

* fixed lambada task

* attempt to bump streaming version

* attempt at using StreamingDataset

* used wrong StreamingDataset spec

* one more misaligned field

* passing shuffle seed to train dataloader

* didn't upload changes to data_c4

* updated config

Co-authored-by: Landan Seguin <landan@mosaicml.com>
Co-authored-by: Matthew <growlix@users.noreply.github.com>
Co-authored-by: dblalock <dwb4ke@virginia.edu>
Co-authored-by: Vitaliy Chiley <vitaliy@mosaicml.com>
Co-authored-by: Jeremy D <115047575+bmosaicml@users.noreply.github.com>
Co-authored-by: Austin <A-Jacobson@users.noreply.github.com>
Co-authored-by: Vitaliy Chiley <vitaliy@moasic.com>
Co-authored-by: dblalock <davis@mosaicml.com>
Co-authored-by: Alex Trott <alex@mosaicml.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>
Co-authored-by: Bandish Shah <bandish@mosaicml.com>
Co-authored-by: bcui19 <bcui8377@gmail.com>
Co-authored-by: Sophia Wisdom <sophiawisdom1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants