Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eval duplicate logging issue #2018

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Mar 1, 2023

What does this PR do?

Fix eval duplicate logging issue. Along for the ride, refactor and clean up console log testing.

image

What issue(s) does this change relate to?

fix CO-1769

Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this! Tests are much better now. Can you add a sample output in the description?

@mvpatel2000 mvpatel2000 merged commit 3d63efe into mosaicml:dev Mar 1, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/rm-end branch March 1, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants