Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wallclock logging to default hours #2005

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Update wallclock logging to default hours #2005

merged 4 commits into from
Feb 28, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Feb 25, 2023 •
edited
Loading

What does this PR do?

Updates runtime estimator and speed monitor to use hours as unit by default when logging

Now in hours
image

What issue(s) does this change relate to?

CO-1839

dakinggg
dakinggg reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't a deficiency of this PR, but I don't like that this change doesn't break any unit tests. Maybe add tests that at least check the order of magnitude of the logged wall clock times? Also please paste some screenshots of output in.

composer/callbacks/runtime_estimator.py Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit e07de7e into mosaicml:dev Feb 28, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/update-wallclocks branch February 28, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@eracah eracah Awaiting requested review from eracah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg