Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HealthChecker Callback #2002

Merged
merged 15 commits into from
Feb 28, 2023
Merged

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Feb 25, 2023

What does this PR do?

Adds a HealthChecker callback to monitor node health. Will log a warning if GPUs on a node appear to be in poor health. Provides an optional interface to send a message via Slack webhook.

Note: this adds the pynvml and slack_sdk to the dependencies. Unsure if this should be in the base install or a separate tag.

TODO:

  • Run some LLM 1B training runs to verify minimal throughput impact

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@hanlint hanlint requested a review from a team as a code owner February 25, 2023 03:19
@mvpatel2000
Copy link
Contributor

Can you please update callbacks.rst to include documentation?

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its on your todo, but can you show a screenshot of a slack alert getting triggered?

setup.py Outdated Show resolved Hide resolved
tests/callbacks/test_health_checker.py Outdated Show resolved Hide resolved
tests/callbacks/test_health_checker.py Outdated Show resolved Hide resolved
tests/callbacks/test_health_checker.py Show resolved Hide resolved
tests/callbacks/test_health_checker.py Show resolved Hide resolved
composer/callbacks/health_checker.py Show resolved Hide resolved
composer/callbacks/health_checker.py Outdated Show resolved Hide resolved
composer/callbacks/health_checker.py Outdated Show resolved Hide resolved
composer/callbacks/health_checker.py Show resolved Hide resolved
composer/callbacks/health_checker.py Outdated Show resolved Hide resolved
@mvpatel2000
Copy link
Contributor

Looks like its on your todo, but can you show a screenshot of a slack alert getting triggered?

image

@nik-mosaic
Copy link
Contributor

No meaningful performance impact on 1B models:
image

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hanlin!

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod 2 minor nits. Great v1! Excited to test it

composer/callbacks/health_checker.py Show resolved Hide resolved
composer/callbacks/health_checker.py Show resolved Hide resolved
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a separate target since it doesn't really fit under dev -- the rest are pretty clearly more dev things and this is not. But no strong opinions

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@hanlint hanlint merged commit 6f68c16 into mosaicml:dev Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants