Add merge_group event trigger to GHA daily workflow #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run workflow on pushes to main and release branches * Run workflow at 2:30am every day on dev * Run workflow manually * Removed run on push to dev
mvpatel2000
reviewed
Feb 24, 2023
mvpatel2000
approved these changes
Feb 24, 2023
We're about to find out! |
|
@mvpatel2000 after clicking "Merge when ready" and the confirmation, looks like the PR gets added to the merge queue which is here: In this case, it started running the |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
bandish-shah
pushed a commit
to bandish-shah/composer
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the
daily.yamlworkflow by adding themerge_groupevent trigger and removing thepushtrigger for thedevbranch. Merge queues were just enabled fordevso the intent is that thedailyworkflow will run on PR's pushed to the merge queue. For more information on merge queues, please see:https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue
The
dailyworkflow is now triggered as follows:Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)