Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log epoch #1986

Merged
merged 8 commits into from
Feb 22, 2023
Merged

fix log epoch #1986

merged 8 commits into from
Feb 22, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Feb 21, 2023 •
edited
Loading

What does this PR do?

Change to trainer/epoch when logging

CO-1812

dakinggg
dakinggg reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you paste in some wandb screenshot to prove it works?

@mvpatel2000
Copy link
Contributor Author

image

Now moved under `/trainer/`

@dakinggg
Copy link
Contributor

Should there be a data point in that image?

@mvpatel2000
Copy link
Contributor Author

mvpatel2000 commented Feb 22, 2023 •
edited
Loading

Should there be a data point in that image?

Hm... I don't know what happened there... I checked again and it's there?? maybe it was buffering...

image

@mvpatel2000
Copy link
Contributor Author

image

Here's a new run new project. I'm going to claim wandb bug

@mvpatel2000 mvpatel2000 merged commit ddf179c into mosaicml:dev Feb 22, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/logger-tweaks branch February 22, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@eracah eracah Awaiting requested review from eracah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg