Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wandb checkpoint logging compatible with wandb model registry #1973

Merged
merged 44 commits into from
Feb 16, 2023

Conversation

growlix
Copy link
Contributor

@growlix growlix commented Feb 15, 2023

What does this PR do?

This PR modifies wandb_logger.py to instantiate model checkpoints as type "model" instead of ".pt", to allow compatibility with W&B's new model registry feature, which MosaicML and WandB are cross-promoting with a demo/webinar next week.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious: do you have a link to a wandb run that used this?

@growlix
Copy link
Contributor Author

growlix commented Feb 16, 2023

@eracah

LGTM. Just curious: do you have a link to a wandb run that used this?
Why yes I do

@growlix growlix merged commit 2d33b7d into mosaicml:dev Feb 16, 2023
dakinggg pushed a commit to dakinggg/composer that referenced this pull request Feb 17, 2023
…osaicml#1973)

This PR modifies `wandb_logger.py` to instantiate model checkpoints as type `"model"` instead of `".pt"`, to allow compatibility with W&B's new model registry feature, which MosaicML and WandB are [cross-promoting with a demo/webinar next week](https://webinar.mosaicml.wandb.events/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants