Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test hf fsdp #1972

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Test hf fsdp #1972

merged 4 commits into from
Feb 25, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Feb 15, 2023 •
edited by jira bot
Loading

What does this PR do?

Add a test for HF + FSDP. Confirmed it would have caught the previous error with the model forward args.

What issue(s) does this change relate to?

CO-1768

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review February 15, 2023 21:02
@dakinggg dakinggg requested a review from bcui19 February 15, 2023 21:02
@dakinggg dakinggg enabled auto-merge (squash) February 15, 2023 21:36
auto-merge was automatically disabled February 23, 2023 23:54

Merge queue setting changed

bcui19
bcui19 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@bcui19 bcui19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for writing it

@dakinggg dakinggg enabled auto-merge (squash) February 25, 2023 00:08
@dakinggg dakinggg merged commit a7afe68 into mosaicml:dev Feb 25, 2023
@dakinggg dakinggg deleted the test_hf_fsdp branch June 1, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcui19 bcui19 bcui19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @bcui19