Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build for kernel v6.13 #173

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix build for kernel v6.13 #173

merged 1 commit into from
Jan 22, 2025

Conversation

amazingfate
Copy link
Contributor

API change since v6.13:

@morrownr
Copy link
Owner

Hi @amazingfate

I was reviewing the changes and I need you to explain the following:

#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 10, 0) && LINUX_VERSION_CODE >= KERNEL_VERSION(5, 4, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(6, 13, 0))

Which is correct 5, 10, 0 or 5, 4, 0?

Thanks for helping.

@amazingfate
Copy link
Contributor Author

amazingfate commented Jan 22, 2025

There are patches in armbian that use 5.4.0: https://github.com/armbian/build/blob/main/patch/misc/wireless-rtl8189es-Fix-VFS-import.patch#L18
Is it okay to use 5.4.0 instead of 5.10.0?

@amazingfate
Copy link
Contributor Author

Now just respect the origin 5.10.0. Feel free to change it if necessary.

@morrownr morrownr merged commit 96c65c5 into morrownr:main Jan 22, 2025
@morrownr
Copy link
Owner

Merged. I have been using 5.10 for a long time. I'm usually pretty careful with that kind of stuff but I may go back and check if I find time.

Thanks again for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants