Rounding liquidate fix #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
adhusson,
Rubilmax,
MerlinEgalite,
MathisGD and
Jean-Grimal
and removed request for
a team
adhusson
approved these changes
Dec 18, 2023
MathisGD
reviewed
Dec 19, 2023
|
Why is it a draft? Because of the certora test? |
MathisGD
reviewed
Dec 20, 2023
Rubilmax
approved these changes
Dec 20, 2023
Merged
MerlinEgalite
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from #638 (comment)
When computing the repaid shares in the case where
seizedAssets != 0, the Liquidation Incentive Factor is used. The change introduced by this PR is safe (safer even), because it corresponds to underestimating the LIF. This is similar to the else branch in the case whereseizedAssets == 0, where it the rounding direction also corresponds to underestimating the LIF