Add liquidate margin test #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
|
Notice that this is the same test as |
MerlinEgalite
previously approved these changes
Nov 21, 2023
This comes from the idea of @daejunpark in #522, where we want to ensure that there is a computation to verify that, even with interest accrual, your borrow position will stay safe. This PR is more modest than testing all the possible functions after some time elapsed, but I think it captures most of the idea |
Rubilmax
suggested changes
Nov 21, 2023
Jean-Grimal
previously approved these changes
Nov 22, 2023
MathisGD
previously approved these changes
Nov 22, 2023
QGarchery
dismissed stale reviews from MathisGD, Jean-Grimal, and MerlinEgalite
via
d87c630
Rubilmax
approved these changes
Nov 22, 2023
Jean-Grimal
approved these changes
Nov 23, 2023
MathisGD
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the computation to make sure that a borrow position is safe (if nothing changes) for a period
elapsed