Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Certora] Liquidity #304

Merged
merged 14 commits into from
Aug 15, 2023
Merged

[Certora] Liquidity #304

merged 14 commits into from
Aug 15, 2023

Conversation

QGarchery
Copy link
Contributor

No description provided.

@QGarchery QGarchery changed the base branch from main to certora/dev August 15, 2023 06:41
@QGarchery QGarchery assigned jhoenicke and unassigned jhoenicke and QGarchery Aug 15, 2023
QGarchery
QGarchery commented Aug 15, 2023
View reviewed changes
Copy link
Contributor Author

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! A few small changes would be nice :)

certora/specs/Blue.spec Outdated Show resolved Hide resolved
src/libraries/SafeTransferLib.sol Show resolved Hide resolved
certora/specs/Blue.spec Outdated Show resolved Hide resolved
certora/specs/Blue.spec Outdated Show resolved Hide resolved
certora/specs/BlueRatioMath.spec Outdated Show resolved Hide resolved
@QGarchery QGarchery mentioned this pull request Aug 15, 2023
Closed
@QGarchery QGarchery added the verif Modifies the formal verification label Aug 15, 2023
QGarchery
QGarchery commented Aug 15, 2023
View reviewed changes
certora/specs/BlueRatioMathSummary.spec Outdated Show resolved Hide resolved
certora/specs/BlueRatioMathSummary.spec Outdated Show resolved Hide resolved
@QGarchery QGarchery marked this pull request as ready for review August 15, 2023 10:25
jhoenicke and others added 2 commits August 15, 2023 12:27
@jhoenicke @QGarchery
Update certora/specs/BlueRatioMathSummary.spec
d3d8086 
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com>
Signed-off-by: Jochen Hoenicke <hoenicke@gmail.com>
@jhoenicke @QGarchery
Update certora/specs/BlueRatioMathSummary.spec
4c4e6cf 
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com>
Signed-off-by: Jochen Hoenicke <hoenicke@gmail.com>
jhoenicke
jhoenicke approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jhoenicke jhoenicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@jhoenicke jhoenicke merged commit 31b9133 into certora/dev Aug 15, 2023
5 checks passed
@jhoenicke jhoenicke deleted the certora/liquiditywip branch August 15, 2023 11:09
@QGarchery QGarchery mentioned this pull request Aug 15, 2023
Closed
9 tasks
@QGarchery QGarchery mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD left review comments

@jhoenicke jhoenicke jhoenicke approved these changes

Assignees
No one assigned
Labels
verif Modifies the formal verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QGarchery @jhoenicke @MathisGD