fix: nonce check #289
Merged
fix: nonce check #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery and
peyha
and removed request for
a team
I've long held that fine tuning the way a signature is used should be outside the scope of what we do, and we should not touch it at all. I would suggest simply using a well established library or implement metatransactions. |
pakim249CAL
approved these changes
Aug 14, 2023
makcandrov
approved these changes
Aug 14, 2023
Jean-Grimal
approved these changes
Aug 14, 2023
MerlinEgalite
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a big issue introduced in #284 (I'm wondering if this refactor is really good in the end). I added some testing for this issue.