Skip interest accrual if already accrued in the same block

[makcandrov]

• Fixes Skip interest accrual if already accrued in the same block? #179

[MathisGD]

Can you provide a gas diff (with your assumptions etc) please

[makcandrov]

The current testing suite already performs several operations in the same block. The gas diff output is as follows:

I created two custom simple tests that execute two operations on the same market, one with 1 block in between, and one without:

[Rubilmax]

@makcandrov can you run the main hardhat test suite pls? It also mines up to 100 blocks 50% of the time, pls?

IMO, having this PR + expecting integrators to accrue interests by exposing the function public is optimal. So we wouldn't need #171 or #138, which are sub-optimal. Offchain, you can just staticcall accrueInterests.

[makcandrov]

Is there an easy way to make a gas diff with hadhat?

[Rubilmax]

Is there an easy way to make a gas diff with hadhat?

There's none, you have to compare results ahah:

EDIT: on avg, the change is insignificant according to hardhat tests. I'll compare by never mining blocks:

EDIT2: perhaps is it because the IRM is too simple? I can't register any difference in gas cost using hardhat tests

[MathisGD]

Is there an easy way to make a gas diff with hadhat?

we could do it though, it does not seem to hard and there are great software devs in this room

[MathisGD]

Can we make sure that with a heavier IRM we have the results that we expect please ?

[makcandrov]

I can't register any difference in gas cost using hardhat tests

I did notice a notable difference with Foundry tests (I also used a custom one without fuzzing) (see here). Can't it be a Hardhat quirk? I don't know much about Hardhat, but is it possible that it skips a block between each call by default?

[makcandrov]

I conducted some debugging, and indeed, by default, a block is mined after each transaction. It can be disabled by specifying it in the config (thanks StackOverflow):

networks: {
  hardhat: {
    mining: {
      auto: false,
      interval: 5000
    }
  }
}

However, with these settings, the liquidation tests fail (even on the main branch), so I'm still investigating...

[makcandrov]

I tried to compare using hardhat, but not mining a block after each transaction produces all kinds of bugs from hardhat. I guess we'll have to settle for Foundry gas diff for now...

[Rubilmax]

I tried it and here's how I made it work: #198

Because blocks are still mined sometimes, only the minimum gas cost is relevant to look at:

[makcandrov]

Very nice, thanks!