Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wad): remove wad constant declaration #176

Merged
merged 3 commits into from
Jul 28, 2023
Merged

refactor(wad): remove wad constant declaration #176

merged 3 commits into from
Jul 28, 2023

Conversation

Rubilmax
Copy link
Contributor

No description provided.

@Rubilmax Rubilmax marked this pull request as ready for review July 25, 2023 14:43
pakim249CAL
pakim249CAL previously approved these changes Jul 25, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Jul 25, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes Jul 26, 2023
View reviewed changes
MerlinEgalite
MerlinEgalite previously approved these changes Jul 27, 2023
View reviewed changes
MathisGD
MathisGD reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely less readable, don't we have a way to import it in an other manner ?

@MerlinEgalite
Copy link
Contributor

this is definitely less readable, don't we have a way to import it in an other manner ?

I tried and unfortunately I could not find a way to do it... 😭

@MathisGD
Copy link
Contributor

It would work if WAD was outside of the lib in FixedPointMathLib.sol but it's not the case. I'm still not 100% convinced that we should not do our own math lib custom for Blue.

@MathisGD
Merge branch 'main' into refactor/wad-constant
d82badf 
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
MathisGD
MathisGD reviewed Jul 27, 2023
View reviewed changes
src/Blue.sol Outdated Show resolved Hide resolved
@MathisGD
fix: merge
8bc8926 
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
MathisGD
MathisGD approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway because with the current state of the code it is better like that.

@MerlinEgalite MerlinEgalite merged commit 30aeb34 into main Jul 28, 2023
2 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/wad-constant branch July 28, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@makcandrov makcandrov makcandrov approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rubilmax @MerlinEgalite @MathisGD @pakim249CAL @Jean-Grimal @makcandrov