Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most SubDL subtitles don't seem to be listed in the manual movie search #2725

Closed
hummingbirdy2 opened this issue Oct 17, 2024 · 5 comments
Closed

Comments

@hummingbirdy2
Copy link

hummingbirdy2 commented Oct 17, 2024

Describe the bug
Even if the subdl API returns available subtitles, they will not be listed in the manual search results.

Expected behavior
Available subtitles should be listed.

Software (please complete the following information):

  • Bazarr: 1.4.5

Additional context
In almost all my tests. No SubDL subtitles are listed in a manual movie search. Although, the API returns a number of subtitles. And that in the bazarr logs, we find the mention Query returned X subtitles.
The only case where I've had a subtitle listed, and that was for American History X with French subtitles.
After looking at the API response, I found that of the 11 subtitles listed, the only one displayed was the one with the key episode non-null.

Listed subtitle item:

{
  "release_name": "658.837.504",
  "name": "SUBDL.com::american.history.x114706.zip",
  "lang": "french",
  "author": "Thz",
  "url": "/subtitle/583867-114706.zip",
  "subtitlePage": "/s/info/MrwXjU1oZ2",
  "season": 0,
  "episode": 4,  // <- non-null
  "language": "FR",
  "hi": true,
  "comment": "658.837.504",
  "releases": [
    "658.837.504"
  ],
  "episode_from": 4,  // <- non-null
  "episode_end": 4,
  "full_season": false
}

Not listed subtitle item:

{
  "release_name": "American.History.X.1998.720p.BluRay.DTS.x264-HiDt.VSS.SB3",
  "name": "SUBDL.com::_american-history-x_french_573944.zip",
  "lang": "french",
  "author": "Esaus",
  "url": "/subtitle/583870-573944.zip",
  "subtitlePage": "/s/info/V40SewVlT3",
  "season": 0,
  "episode": null,  // <- null
  "language": "FR",
  "hi": true,
  "comment": "",
  "releases": [
    "American.History.X.1998.720p.BluRay.DTS.x264-HiDt.VSS.SB3"
  ],
  "episode_from": null,  // <- null
  "episode_end": 0,
  "full_season": false
}

At first glance, bazarr doesn't seem to list subtitles if the episode key is null. And this seems to be confirmed by my other searches: subtitles for films with this null key are never listed.
I didn't check if this behaviour is the same with automatic search.

@VXsz
Copy link

VXsz commented Oct 21, 2024

Yes, this issue seems has been there for like 2 months by now, both on my windows, and a friend's pretty fresh windows install. The automatic search has the same issue and it won't grab subs automatically (the api returns a small set of subs, but it filters all of them away like explained by hummingbirdy2). Weirdly enough it sometimes does grab a subtitle.
Most of the new shows in my library have no subs even tho they are pretty popular and have good matching subs.

@morpheus65535
Copy link
Owner

@hummingbirdy2 it should eb fixed in upcoming beta. We shouldn't compare episode_from and episode_end for movies anyway.

@VXsz We do not support season packs for series so it could be the reason why. The other reason may be that they provide garbage in their API from time to time. They were suppose to properly reindex their stuff but they never confirmed it was done.

@morpheus65535
Copy link
Owner

@hummingbirdy2 can I close this issue? Is it fixed?

@hummingbirdy2
Copy link
Author

Sorry, I didn't take the time to test the beta. I'll do it soon as possible.

@hummingbirdy2
Copy link
Author

Looks good to me, thanks for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants