-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most SubDL subtitles don't seem to be listed in the manual movie search #2725
Comments
Yes, this issue seems has been there for like 2 months by now, both on my windows, and a friend's pretty fresh windows install. The automatic search has the same issue and it won't grab subs automatically (the api returns a small set of subs, but it filters all of them away like explained by hummingbirdy2). Weirdly enough it sometimes does grab a subtitle. |
@hummingbirdy2 it should eb fixed in upcoming beta. We shouldn't compare @VXsz We do not support season packs for series so it could be the reason why. The other reason may be that they provide garbage in their API from time to time. They were suppose to properly reindex their stuff but they never confirmed it was done. |
@hummingbirdy2 can I close this issue? Is it fixed? |
Sorry, I didn't take the time to test the beta. I'll do it soon as possible. |
Looks good to me, thanks for the fix 👍 |
Describe the bug
Even if the subdl API returns available subtitles, they will not be listed in the manual search results.
Expected behavior
Available subtitles should be listed.
Software (please complete the following information):
Additional context
In almost all my tests. No SubDL subtitles are listed in a manual movie search. Although, the API returns a number of subtitles. And that in the bazarr logs, we find the mention
Query returned X subtitles
.The only case where I've had a subtitle listed, and that was for American History X with French subtitles.
After looking at the API response, I found that of the 11 subtitles listed, the only one displayed was the one with the key
episode
non-null.Listed subtitle item:
Not listed subtitle item:
At first glance, bazarr doesn't seem to list subtitles if the
episode
key is null. And this seems to be confirmed by my other searches: subtitles for films with this null key are never listed.I didn't check if this behaviour is the same with automatic search.
The text was updated successfully, but these errors were encountered: