Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 모립세트 페이지 폴더구조 변경 #238

Merged
merged 2 commits into from
Dec 30, 2024
Merged

[Refactor] 모립세트 페이지 폴더구조 변경 #238

merged 2 commits into from
Dec 30, 2024

Conversation

Ivoryeee
Copy link
Collaborator

@Ivoryeee Ivoryeee commented Dec 29, 2024 •
edited by suwonthugger
Loading

🔥 Related Issues

✅ 작업 리스트

  • 허용서비스 폴더 구조 수정

🔧 작업 내용

components 폴더를 없애고, 각 컴포넌트의 폴더를 만들어 구조를 변경

🧐 새로 알게된 점

🤔 궁금한 점

📸 스크린샷 / GIF / Link

image

@Ivoryeee Ivoryeee added the ♻️ Refactor 코드 리팩토링 label Dec 29, 2024
@Ivoryeee Ivoryeee added this to the 폴더 구조 리팩토링 milestone Dec 29, 2024
@Ivoryeee Ivoryeee self-assigned this Dec 29, 2024
@Ivoryeee Ivoryeee linked an issue Dec 29, 2024 that may be closed by this pull request
[ Refactor ] 모립세트 페이지 폴더 구조 변경 #237
Closed
2 tasks
suwonthugger
suwonthugger reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@suwonthugger suwonthugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

src/pages/AllowedServicePage/AllowedServicePage.tsx Show resolved Hide resolved
suwonthugger
suwonthugger approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@suwonthugger suwonthugger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 빠른 반영 감사드려요~~~!!

seueooo
seueooo approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@seueooo seueooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

KIMGEONHWI
KIMGEONHWI approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@KIMGEONHWI KIMGEONHWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@Ivoryeee Ivoryeee merged commit f843915 into develop Dec 30, 2024
1 check passed
@suwonthugger suwonthugger deleted the refactor/#237/allowedService-folder-structure branch January 1, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMGEONHWI KIMGEONHWI KIMGEONHWI approved these changes

@seueooo seueooo seueooo approved these changes

@suwonthugger suwonthugger suwonthugger approved these changes

Assignees

@Ivoryeee Ivoryeee

Labels
♻️ Refactor 코드 리팩토링 size/M
Projects
Morib-Client
Status: Done
Milestone
폴더 구조 리팩토링
Development

Successfully merging this pull request may close these issues.

[ Refactor ] 모립세트 페이지 폴더 구조 변경
4 participants
@Ivoryeee @KIMGEONHWI @seueooo @suwonthugger