Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Improvements #109

Closed
andreaSimonePorceddu opened this issue Nov 5, 2021 · 2 comments
Closed

Spec Improvements #109

andreaSimonePorceddu opened this issue Nov 5, 2021 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@andreaSimonePorceddu
Copy link
Collaborator

andreaSimonePorceddu commented Nov 5, 2021

This is a proposal to improve the default slice interfaces in order to have a more scalable system and a more intuitive theme building.

Sizes

The xxs and xxl could become 2xs and 2xl in order to suggest a more scalable naming for all sizes props.

Font Slice

As the font slice keys could be used to define different fonts and even the same fonts with different weights and styles it could be better to leave this slice more flexible by changing regular, medium, bold to just one default property default.

Borders

primary and secondary keys seem to not work properly to define borders. We could change them with some more appropriate like thin and `bold.

Zindices

light, soft and strong keys seem to not work properly to define zIndices. We could change them with some more appropriate like `lowest, lower, low, high, higher, highest.

@mauroerta
Copy link
Collaborator

mauroerta commented Nov 5, 2021

I agree with the new interfaces, steps needed if we want to change those interfaces are:

  • update @morfeo/spec package
  • update @morfeo/preset-default
  • re-build the theme and update css inside the web-extension
  • update the docs

Will you do it? I can help you with the update of the documentation.

@mauroerta mauroerta added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 5, 2021
andreaSimonePorceddu added a commit that referenced this issue Nov 5, 2021
@andreaSimonePorceddu
Copy link
Collaborator Author

closed with PR #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants