Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Buy licenses you have meta data for #2

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

Flek26
Copy link
Contributor

@Flek26 Flek26 commented Apr 4, 2023

Update wording on My Info tab: https://i.imgur.com/6DVVHZF.png

With Meta Data for licenses: https://i.imgur.com/SKaMMsa.png
Without Meta Data: https://i.imgur.com/orP5uhO.png

Can now close using escape

@NietThijmen
Copy link
Member

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

@Flek26
Copy link
Contributor Author

Flek26 commented Apr 4, 2023

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

@NietThijmen
Copy link
Member

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

In client/nui.lua you at line 58 you hardcoded the items[1] would this have any reason? As that makes it less configurable

And the other one i appear to be stupid, as Player licenses doesnt have a number as key. So i thats fine

@Flek26
Copy link
Contributor Author

Flek26 commented Apr 4, 2023

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

In client/nui.lua you at line 58 you hardcoded the items[1] would this have any reason? As that makes it less configurable

And the other one i appear to be stupid, as Player licenses doesnt have a number as key. So i thats fine

The reason for that is ID_Card does not contain a Meta option for it. So this way ID_Card is always allowed to be purchased. If you don't want them able to purchase id_card - remove the hard code option and remove it from the config.

@NietThijmen
Copy link
Member

LGTM

@NietThijmen NietThijmen merged commit 396b59e into morethancodenl:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants