Only the template engine sequence

.moban.cd/changelog.yml

@@ -6,6 +6,7 @@ releases:
     details:
     - "`#253`: symbolic link in regression pack causes python setup.py to do recursive include"
     - "`#209`: Alert moban user when `git` is not available and is used."
+    - "`#261`: since moban group template files per template type, this fill use first come first register to order moban group"
   date: unreleased
   version: 0.4.3
 - changes:

CHANGELOG.rst

@@ -11,6 +11,9 @@ Removed
    regression pack causes python setup.py to do recursive include
 #. `#209 <https://github.com/moremoban/moban/issues/209>`_: Alert moban user
    when `git` is not available and is used.
+#. `#261 <https://github.com/moremoban/moban/issues/261>`_: since moban group
+   template files per template type, this fill use first come first register to
+   order moban group
 
 0.4.2 - 08.03.2019
 --------------------------------------------------------------------------------

moban/mobanfile/__init__.py

@@ -1,7 +1,7 @@
 import os
 import re
 import sys
-from collections import defaultdict
+from collections import OrderedDict
 
 from lml.utils import do_import
 
@@ -112,7 +112,7 @@ def _iterate_list_of_dicts(list_of_dict):
 
 def handle_targets(merged_options, targets):
     list_of_templating_parameters = parse_targets(merged_options, targets)
-    jobs_for_each_engine = defaultdict(list)
+    jobs_for_each_engine = OrderedDict()
 
     for target in list_of_templating_parameters:
         forced_template_type = merged_options.get(
@@ -129,6 +129,9 @@ def handle_targets(merged_options, targets):
             ]
             target.set_template_type(primary_template_type)
 
+        if primary_template_type not in jobs_for_each_engine:
+            jobs_for_each_engine[primary_template_type] = []
+
         jobs_for_each_engine[primary_template_type].append(target)
 
     count = 0

tests/mobanfile/test_mobanfile.py

@@ -143,3 +143,45 @@ def test_handle_targets(fake_renderer):
             )
         ],
     )
+
+
+@patch("moban.plugins.template.MobanEngine.render_to_files")
+def test_handle_targets_sequence(fake_renderer):
+    from moban.mobanfile import handle_targets
+
+    TEMPLATE1 = "a.template.jj2"
+    OUTPUT1 = "filterme.handlebars"  # in the future, this could dynamic output
+    OUTPUT2 = "filtered_output.txt"
+    CONFIGURATION = "child.yaml"
+    TEMPLATE_DIRS = [os.path.join("tests", "fixtures", "mobanfile")]
+    DEFAULT_TEMPLATE_TYPE = "jinja2"
+
+    options = dict(
+        configuration=CONFIGURATION,
+        template_type=DEFAULT_TEMPLATE_TYPE,
+        template_dir=TEMPLATE_DIRS,
+        configuration_dir=os.path.join("tests", "fixtures"),
+    )
+    short_hand_targets = [{OUTPUT1: TEMPLATE1}, {OUTPUT2: OUTPUT1}]
+    handle_targets(options, short_hand_targets)
+
+    call_args = list(fake_renderer.call_args_list)
+
+    eq_(
+        call_args[0][0][0][0],
+        TemplateTarget(
+            "a.template.jj2",
+            "child.yaml",
+            "filterme.handlebars",
+            template_type="jj2",
+        ),
+    )
+    eq_(
+        call_args[1][0][0][0],
+        TemplateTarget(
+            "filterme.handlebars",
+            "child.yaml",
+            "filtered_output.txt",
+            template_type="handlebars",
+        ),
+    )