Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Code refactoring #147

Merged
merged 1 commit into from
Jan 5, 2019
Merged

🔨 Code refactoring #147

merged 1 commit into from
Jan 5, 2019

Conversation

CLiu13
Copy link
Collaborator

@CLiu13 CLiu13 commented Jan 4, 2019

Related to #146

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?
  7. please add your name and github link to contributors.rst in alphabetical order.

@CLiu13 CLiu13 requested a review from chfw January 4, 2019 18:38
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #147 into dev will increase coverage by 0.4%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #147     +/-   ##
=========================================
+ Coverage   97.03%   97.44%   +0.4%     
=========================================
  Files          40       40             
  Lines        1925     1916      -9     
=========================================
- Hits         1868     1867      -1     
+ Misses         57       49      -8
Impacted Files Coverage Δ
moban/plugins.py 96.5% <88.23%> (+5.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1eb42...61889f3. Read the comment docs.

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@chfw chfw merged commit 561ff52 into moremoban:dev Jan 5, 2019
@chfw chfw mentioned this pull request Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants